code collapse bug

[blepore]

When one enables code collapse, if you collapse an if condition it does not just collapse the if statement, but it also includes the else code in the collapse. Consider the following type of PHP code.

Code: Select all

if (true) {
   echo 'true';
} else {
   echo 'false';
}

If the else condition is on the same line as the collapse, I would be okay with just collapsing the text between the if and the closing bracket, leaving the bracket where it was.

[Gatis]

At the moment this is the intended behaviour at least until majority of customers shall ask for other implementation of this feature.
The same functionality is used also in some other editors that support code collapse. For example, Notepad ++.

[joemichaud]

Sorry to contradict, but I actually prefer it the way it is now.

[syrupcore]

Sorry to contradict, but I actually prefer it the way it is now.

me too.

[blepore]

At the moment this is the intended behaviour at least until majority of customers shall ask for other implementation of this feature.
The same functionality is used also in some other editors that support code collapse. For example, Notepad ++.

Oh I did not mean to come off like I believed this was a bug. My hope was to have an option to change this type of behavior, because it doesn't seem to make much sense to me. When I want to hide a portion of code from view I would like to only hide the current block. To me it feels like the if and the else should be considered separate blocks to be collapsible. It's been a while since I've used an editor with this feature, but I know that this is the Dreamweaver 8 method of collapsing.

I fully understand the need to listen to your customer base. This isn't a make or break feature for me. Just would be nice. I'd be much happier for better JSON support, but that's a whole nother post.

[blepore]

Just for clarities sake, I meant the DW8 method was the way I was suggesting, not the way it is done presently. Would be nice to toggle it on with an option but I more than fully understand the purpose in only offering one way of doing things.

[Gatis]

Tanks for your explanation, blepore. Sorry if I sounded rude.
Well, I have not used Dreamweaver myself, so I do not not how did they implement this. The problem I see here is that the closing mark of a block - '}' and also the opening one - '{' are on the same line.
Right now the code is collapsed including the last line where '}' is. Because of this it is not possible to have the same line with opening mark '{' being visible.
We would have to implement another complicated code collapse algorithm and also add an option.
Until substantial count of customers will be asking for this, we shall concentrate on improving or adding features that are more important.

[blepore]

Tanks for your explanation, blepore. Sorry if I sounded rude.
Well, I have not used Dreamweaver myself, so I do not not how did they implement this. The problem I see here is that the closing mark of a block - '}' and also the opening one - '{' are on the same line.
Right now the code is collapsed including the last line where '}' is. Because of this it is not possible to have the same line with opening mark '{' being visible.
We would have to implement another complicated code collapse algorithm and also add an option.
Until substantial count of customers will be asking for this, we shall concentrate on improving or adding features that are more important.

Oh, I did not feel that you were being rude. I completely understand the need to keep things simple.

Basically the DW8 method is to always leave the }. Even if there is nothing on the line after the }, or if the } is on the same line as the { the collapsing just collapses the content within the braces, but not the braces.

I tried to upload an attachment to show what I meant, but I'm getting "Could not upload attachment to ./files/3189_af30598cc70f315a7181122e75626661.". Ahh well.

[chrisjlocke]

Email me the attachment and I'll host it for you, if needed.

[blepore]

Email me the attachment and I'll host it for you, if needed.

Oh I've got enough hosting. What is the policy on posting pictures on this forum? I figured that attachments were down I thought they were disabled and thus I should link anything.