Bugs + Suggestion: JavaScript Formatter Settings

[pmk65]

The indentation settings "JavaScript Formatter Settings" should be identical to the indentation settings in Preferences -> Text Settings -> General. Currently you risk ending up with an indentation that doesn't match the editor settings if you forgot to set the "JavaScript Formatter settings" identically.

I really don't see any reason for setting the indentation differently than the Editor settings. So maybe the indentation settings should be removed from "JavaScript Formatter Settings" and instead use the Editor indentation settings?


Bug 1: Also if I click the "Indent Size" arrows rapidly in "JavaScript Formatter Settings", I get an error alert (Probably because the preview is still rendering).


Bug 2: The Break before/after brackets settings seems to be ignored.

Example. I have a simple code snippet that looks like this:

Code: Select all

var waitTimerID = setInterval(function() {
    // code here
});

Then I run the JavaScript formatter with NONE of the "Break" checkboxes checked, and ends up with this:

Code: Select all

var waitTimerID = setInterval(function()
    {
        // code here
    }
);

Which is clearly wrong, as I DIDN'T want it to break before/after the brackets.
And if I check all the "Break" checkboxes, I end up with the exact same result.

[Aivars]

Thank you for the suggestions. I think your point about indentation settings is fair, and the chosen solution should probably apply to all other formatters as well, so we will consider this suggestion for the next major version.
I also added the bugs to the list.